feat(image): add image preview description template #16500
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
denyssalon
changed the title
| @@ -29,4 +29,9 @@ export interface ImageTemplates { | |||
| * Custom template of closeicon. | |||
| */ | |||
| closeicon(): TemplateRef<any>; | |||
|
|
|||
| /** | |||
| * Custom template of imagedescription. | |||
There was a problem hiding this comment.
space here? image description
There was a problem hiding this comment.
@SoyDiego It is a name of the template which is imagedescription (without space).
I made it the same way as comments above (closeicon, rotaterighticon etc). Do you still want me to put a space there?
There was a problem hiding this comment.
oh ok, sorry, thanks for re check!
Now we should wait if PrimeNG Team approve it!
|
Hello @SoyDiego. Do you think this has a chance to be merged someday? |
Sorry, i'm not part of PrimeNG Team, only a contributor like you :). |
|
Hi @denyssalon, Thanks a lot for your contribution! Can you create an issue and link it? Then, I'll merge it asap. Also, could you please create a PR for v18 as well? |
mertsincan
added
the
Resolution: Needs Issue
Feature Requests
This PR extends image component with custom image preview description template
